Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in arg of log #187

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Fill in arg of log #187

merged 1 commit into from
Dec 28, 2023

Conversation

Smaug123
Copy link
Contributor

@Smaug123 Smaug123 commented Dec 27, 2023

Trivial one.

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nojaf nojaf merged commit da74b71 into ionide:main Dec 28, 2023
2 checks passed
@Numpsy
Copy link
Contributor

Numpsy commented Dec 30, 2023

On a related note, there are Roslyn analysers about that try to detect these sorts of issues in C# code for at least MEL and Serilog, so maybe that's something useful to port? (not that I could say offhand how much effort there is in porting the message template code)

@Smaug123
Copy link
Contributor Author

The converse ("you passed a function as a logging arg") is one of the G-Research analysers; seems sensible to have this one too!

@Smaug123 Smaug123 deleted the fill-in-log branch December 30, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants